Closed
Conversation
- Add support for Fulu network fork with custom fork digests - Update Go to 1.24.5 and upgrade dependencies - Remove unused cpyStatusAny and deprecated cpyStatus helpers - Skip TestReqResp_ProtocolRequests to prevent CI failures
mattevans
force-pushed
the
feat/hermes-fulu-support
branch
from
ffc5561 to
09f75ea
Compare
Savid
approved these changes
Aug 25, 2025
samcm
approved these changes
Aug 25, 2025
Contributor
|
It looks really good on my end. Thanks, @mattevans, for the hard work and for contributing upstream! The only thing that I'm slightly worried about is the peer discovery:
// line 192
if !bytes.Equal(forkEntry.CurrentForkDigest, digest[:]) {
// irrelevant network
continue
}Let's coordinate on this. I'm also happy to give a hand here |
Merged
Contributor
|
Closing this in favour of #79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Fulu fork changes with BPO support.
Changes
FetchAndSetBlobSchedule()to fetch and configure BPO schedule from beacon node, ensuring correct fork digest calculation.StatusHolder,MetadataHolder) to handle multiple protocol versions.StatusV2andMetadataV3(returnsMetaDataV2type) RPC handlers with proper protocol registration.StatusV1orStatusV2based on Fulu fork activation.SetStatusV1/SetStatusV2andSetMetaDataV2methods.network/forksimport, removed upstream in Prysm.ETH2Keyconstant with hardcoded "eth2" string for ENR entries, removed upstream in Prysm.Testing:
Kurtosis Config (fusaka.yaml)
Run cmd
go run ./cmd/hermes \ --data.stream.type=output \ --log.level=warn \ eth \ --chain=devnet \ --prysm.host=127.0.0.1 \ --prysm.port.grpc=43005 \ --prysm.port.http=43001 \ --libp2p.host=0.0.0.0 \ --genesis.ssz.url=http://127.0.0.1:40000/network-configs/genesis.ssz \ --config.yaml.url=http://127.0.0.1:40000/network-configs/config.yaml \ --bootnodes.yaml.url=http://127.0.0.1:40000/network-configs/boot_enr.yaml \ --deposit-contract-block.txt.url=http://127.0.0.1:40000/network-configs/deposit_contract_block.txtNote
Updates prysm dep to latest
developcommit. They are actively working on merging fulu support into theirdevelopbranch. We can probably wait for them to cut an official release before we update the dep and merge.